Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a R-cmd-check workflow #42

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added a R-cmd-check workflow #42

wants to merge 6 commits into from

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Jun 6, 2023 •
edited
Loading

R-CMD-check.yml

This creates additonal issues to correct. Some of which are done here.

  • added badge to readme
  • updated R dependsin DESCRIPTION
  • fixed teamMembers vignette header yaml
  • added content to gitignore

OTHER STUFF TO FOLLOW

@andybeet andybeet linked an issue Jun 7, 2023 that may be closed by this pull request
compress large data files #44
Open
@jmhatch
Copy link
Member

jmhatch commented Jun 15, 2023

I think compressing large data files is a good idea, @andybeet! I did a quick check and it looks like the *.rda files are already compressed, but maybe not optimal? I also changed data/Herring_Management_Areas.rda and data/NAFO_Divisions_2021_line_enclosed.rda to have bzip2 compression (they were gzip, while everything else was bzip2). I think this R pkg is going to be big.

> ## paths to *.rda images
> paths <- sort(Sys.glob('data/*.rda'))
> 
> ## check compression
> chk_comp <- tools::checkRdaFiles(paths)
> chk_comp
                                                          size ASCII compress version
data/amapps_grid.rda                                     35462 FALSE    bzip2       2
data/BTS_Strata.rda                                     925563 FALSE    bzip2       2
data/EcoMon_Strata.rda                                  364960 FALSE    bzip2       2
data/epu_sf.rda                                         438176 FALSE    bzip2       2
data/final_mass_inshore_stat.rda                       1418389 FALSE    bzip2       2
data/GillnetClosureAreas_20211021.rda                     1742 FALSE    bzip2       2
data/Great_South_Channel_Restricted_Trap_Pot_Area.rda     1785 FALSE    bzip2       2
data/Herring_Management_Areas.rda                      4451806 FALSE    bzip2       3
data/LMA1_Restricted_Area_FR.rda                          1410 FALSE    bzip2       2
data/NAFO_Divisions_2021_line_enclosed.rda              105254 FALSE    bzip2       3
data/NAFO_Divisions_2021_line_not_enclosed.rda           86527 FALSE    bzip2       2
data/NAFO_Divisions_2021_poly_clipped.rda              3005125 FALSE    bzip2       2
data/NAFO_Divisions_2021_poly_not_clipped.rda           106522 FALSE    bzip2       2
data/Shellfish_Strata.rda                               108757 FALSE    bzip2       2
data/Shrimp_Strata.rda                                   25715 FALSE    bzip2       2
data/Statistical_Areas_2010.rda                       12492084 FALSE    bzip2       2
data/Statistical_Areas_2010_withNames.rda             12500689 FALSE    bzip2       2

@andybeet
Copy link
Member Author

andybeet commented Apr 4, 2024

@jmhatch how did you change the compression from gzip to bzip2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compress large data files
2 participants
@andybeet @jmhatch